feat: support lists in 'resolve_keyed_by' #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
push-zptlxmssuqnn
branch
2 times, most recently
from
5daf787 to
8c4f563
Compare
jcristau
requested changes
Nov 26, 2024
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Looks like this breaks on python 3.8?
hneiva
reviewed
Nov 27, 2024
Contributor
|
Moving this back to draft to get it out of review queues. |
Collaborator
Author
|
Oops, I forgot about this PR.. I'll get it into shape soon |
ahal
force-pushed
the
push-zptlxmssuqnn
branch
from
8c4f563 to
4ed10f0
Compare
jcristau
reviewed
Jan 10, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Is this worth an addition to the "Keyed By" section of docs/concepts/transforms.rst, or an example somewhere?
ahal
force-pushed
the
push-zptlxmssuqnn
branch
from
4ed10f0 to
89a1539
Compare
bhearsum
approved these changes
Jan 20, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
The doc improvements here are fantastic!
jcristau
reviewed
Jan 20, 2025
Collaborator
Author
|
I didn't end up needing this for the thing I was working on at the time, so I've neglected it again.. but I'll try and get this landed at some point. |
ahal
commented
May 29, 2025
bhearsum
force-pushed
the
push-zptlxmssuqnn
branch
from
a918ca6 to
4e3cfb4
Compare
Contributor
I'm assuming this was related to the typing that @hneiva called out, and has since been fixed... |
ahal
requested review from
bhearsum and
jcristau
and removed request for
jcristau
bhearsum
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this in Gecko and it resulted in an identical full graph