Skip to content

fix: transifex sync scripts and regional translations #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovitrif merged 6 commits into from
Jan 22, 2026
Merged

fix: transifex sync scripts and regional translations #714

ovitrif merged 6 commits into from
Jan 22, 2026
+3,501 −1,397

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 22, 2026 •
edited
Loading

This PR:

  1. Completes missing translations for Italian, Spanish Spain, and Portuguese Brazil locales
  2. Adds push/pull scripts for Transifex with proper regional locale handling
  3. Normalizes translation files to match Transifex format

Description

  • Adds 2 missing Italian strings (lightning funding buttons)
  • Creates complete Spanish Spain (es-rES) translations with 994 strings
  • Creates complete Portuguese Brazil (pt-rBR) translations with 997 strings
  • Updates pull script to handle Android locale format conversion (es_ES to es-rES, pt_BR to pt-rBR, es_419 to b+es+419)
  • Adds new push script that temporarily converts Android format to Transifex format for uploads
  • Normalizes all translation files to alphabetical key order matching Transifex

Preview (Transifex Resources Snapshot)

Arc 2026-01-22 002828

QA Notes

  1. ✅ Manually test changing the App language via Settings, without restarting the app
  2. ✅ Verify in Transifex Dashboard all translations above 0% are at 100% ✅
  3. ✅ Do a a transifex force push + pull → expect zero changes
  4. ✅ Run the custom transifex scripts → expect success:
./scripts/translations-ush.sh
./scripts/translations-pull.sh

@ovitrif ovitrif changed the title fix: complete regional translations and add sync scripts fix: transifex sync scripts and regional translations Jan 22, 2026
@claude

This comment has been minimized.

Sign in to view
@ovitrif ovitrif self-assigned this Jan 22, 2026
ovitrif and others added 6 commits January 22, 2026 21:08
@ovitrif @claude
fix: complete Italian translations
d063567 
Add missing Italian translations for:
- lightning__funding_advanced__button1
- lightning__funding_advanced__button2

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ovitrif @claude
fix: complete Spanish Spain (es_ES) translations
db2d602 
Add 417 missing Spanish Spain translations to bring es_ES locale
from 58% to 100% coverage.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ovitrif @claude
fix: complete portuguese brazil translations
b057803 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ovitrif @claude
fix: update pull script for regional locales
7d0b1d3 
Update locale handling to use proper Android format:
- es_ES -> es-rES (Spanish Spain)
- pt_BR -> pt-rBR (Portuguese Brazil)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ovitrif @claude
feat: add push script for regional locales
c987532 
Handles directory naming conversion between Android format
and Transifex format:
- values-es-rES <-> values-es_ES
- values-pt-rBR <-> values-pt_BR
- values-b+es+419 <-> values-es_419

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ovitrif @claude
chore: normalize translation files to match Transifex format
e2f79a2 
Accept Transifex's alphabetical key ordering to ensure
future push+pull cycles result in zero changes.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ovitrif ovitrif enabled auto-merge January 22, 2026 20:09
jvsena42
jvsena42 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@jvsena42 jvsena42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: still missing some Bitrefill translations. can be done on other PR

image

@ovitrif ovitrif merged commit b10afde into master Jan 22, 2026
28 of 32 checks passed
@ovitrif ovitrif deleted the fix/regional-t10s branch January 22, 2026 21:05
@ovitrif
Copy link
Collaborator Author

ovitrif commented Jan 22, 2026

nit: still missing some Bitrefill translations. can be done on other PR

image

Thanks, strange!

Adding a separate issue for these

This was referenced Jan 22, 2026
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvsena42 jvsena42 jvsena42 approved these changes

@ben-kaufman ben-kaufman Awaiting requested review from ben-kaufman

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@ovitrif ovitrif

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif @jvsena42