Skip to content

fix: remove external node custom fee #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovitrif merged 2 commits into from
Jan 23, 2026
Merged

fix: remove external node custom fee #685

ovitrif merged 2 commits into from
Jan 23, 2026
+6 −266

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 20, 2026 •
edited
Loading

Closes #548

Description

Removes the SetCustomFee feature from the External Node flow as it had no functional effect on the actual fee of the channel opening transaction.

Changes

  • Removed ExternalFeeCustomScreen and related navigation
  • Simplified ExternalConfirmScreen network fee display to read-only
  • Removed customFeeRate state from ExternalNodeViewModel
  • Fee is now calculated using default transaction speed from settings
  • Updated e2e-test-ids.md to mark SetCustomFee as descoped

Preview

Android.Studio.2026-01-23.002848.mp4

Testing

  1. Use guide in https://github.com/synonymdev/bitkit-docker?tab=readme-ov-file#external-node-channel
  2. 🟢 Verify Manual setup flow shows no more custom fee screen on tap of network fee in the confirmation screen.

@ovitrif ovitrif changed the title refactor: remove non-functional custom fee feature refactor: remove external node custom fee Jan 20, 2026
@ovitrif ovitrif force-pushed the claude/issue-548-20260120-1551 branch from 8aa1dd1 to ebf958f Compare January 22, 2026 23:25
@ovitrif ovitrif self-assigned this Jan 23, 2026
@ovitrif ovitrif marked this pull request as ready for review January 23, 2026 01:04
@ovitrif ovitrif requested a review from piotr-iohk January 23, 2026 01:05
@ovitrif ovitrif changed the title refactor: remove external node custom fee fix: remove external node custom fee Jan 23, 2026
@ovitrif ovitrif requested a review from jvsena42 January 23, 2026 01:05
@ovitrif ovitrif enabled auto-merge January 23, 2026 01:06
@ovitrif
refactor: remove external node custom fee #548
ef65734 
Remove SetCustomFee feature from External Node flow as it had
no effect on the channel opening transaction fee.

- Remove ExternalFeeCustomScreen and related navigation
- Simplify ExternalConfirmScreen network fee display
- Remove customFeeRate state from ExternalNodeViewModel
- Update e2e-test-ids.md to mark SetCustomFee as descoped
@ovitrif ovitrif force-pushed the claude/issue-548-20260120-1551 branch from ebf958f to ef65734 Compare January 23, 2026 01:07
@claude

This comment has been minimized.

Sign in to view
@ovitrif ovitrif mentioned this pull request Jan 23, 2026
Open
jvsena42
jvsena42 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very contained change

@ovitrif ovitrif merged commit 96bf3f6 into master Jan 23, 2026
20 of 23 checks passed
@ovitrif ovitrif deleted the claude/issue-548-20260120-1551 branch January 23, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvsena42 jvsena42 jvsena42 approved these changes

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@ovitrif ovitrif

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove SetCustomFee feature when setting up external channel

3 participants

@ovitrif @jvsena42