Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 23, 2026

Description

  1. Updates ldk-node to v0.7.0-rc.11 and bitkit-core to 0.1.37
  2. Replaces the custom amountOnClose calculation with the authoritative claimableOnCloseSats from ldk-node's channel monitor

QA Notes

Use CI checks.

@claude

This comment has been minimized.

@ovitrif ovitrif closed this Jan 23, 2026
@ovitrif ovitrif reopened this Jan 23, 2026
@ovitrif ovitrif changed the base branch from master to claude/issue-548-20260120-1551 January 23, 2026 03:27
@ovitrif ovitrif changed the title feat: optimize ldk-node usage and remove external fee screen chore: use latest ldk-node and bitkit-core Jan 23, 2026
@ovitrif ovitrif changed the title chore: use latest ldk-node and bitkit-core chore: integrate latest ldk-node and bitkit-core Jan 23, 2026
@jvsena42
Copy link
Member

nit: could remove // TODO: Remove lowercase workaround when https://github.com/synonymdev/bitkit-core/issues/66 is fixed

jvsena42
jvsena42 previously approved these changes Jan 23, 2026
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from claude/issue-548-20260120-1551 to master January 23, 2026 11:08
@ovitrif ovitrif dismissed jvsena42’s stale review January 23, 2026 11:08

The base branch was changed.

@jvsena42 jvsena42 enabled auto-merge January 23, 2026 11:13
@jvsena42
Copy link
Member

jvsena42 commented Jan 23, 2026

@piotr-iohk there is a bug in the input. It is pasting the text before deleting the previous
https://github.com/synonymdev/bitkit-android/actions/runs/21273462211/job/61260296879?pr=718

Or maybe it is just part of the test 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants