implement fallback conj to fix dot#233
Merged
isuruf merged 3 commits intosymengine:masterfrom Oct 1, 2021
Merged
Conversation
Member
This is almost true. For |
Contributor
Author
|
What about the updated version? I get julia> using SymEngine
julia> conj(2 * IM)
-2*im |
Contributor
Author
|
This should also make #196 obsolete |
Member
|
Thanks |
Contributor
Author
|
Well, thank you for this nice package - great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now on
master,realetc. is not really working properly right now, see #110 andThus, this implemented fallback
conj(x) = xis in accordance with the sensible definitionfor complex numbers.
I would like to get this merged into a new release of SymEngine.jl to allow further working with
dotproducts of symbolic variables (which seem to be mostly real). Extensions to a proper support of complex numbers and further fixes should be discussed in #110 etc.This fixes a problem reported by @ketch (
dotproduct involvingSymEngine.Basicvariables representing real numbers).