Array{SymEngine.Basic,1} dot product#196
Open
stefanbringuier wants to merge 1 commit intosymengine:masterfrom
Open
Array{SymEngine.Basic,1} dot product#196stefanbringuier wants to merge 1 commit intosymengine:masterfrom
stefanbringuier wants to merge 1 commit intosymengine:masterfrom
Conversation
… Array{SymEngine.Basic,1} (vector) dot product. The method is still bound to LinearAlgebra.jl.
isuruf
reviewed
Feb 13, 2020
| @@ -0,0 +1,112 @@ | |||
| # To use SymEngine from another CMake project include the following in your | |||
Member
There was a problem hiding this comment.
Can you remove the deps/libsymengine-0.4 folder?
Contributor
|
I think this can be closed since everything works after #233 has been merged: julia> using SymEngine, LinearAlgebra
julia> v = [ symbols("v_$i") for i=1:4 ]
4-element Vector{Basic}:
v_1
v_2
v_3
v_4
julia> dot(v, v)
v_1^2 + v_2^2 + v_3^2 + v_4^2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added linalgebra.jl which includes proper method(dispatch) for taking Array{SymEngine.Basic,1} (vector) dot product. The method is still bound to LinearAlgebra. This file can serve as a proper place to provide additional SymEngine.jl linear algebra support.