Skip to content

fix(kde): use core instead of std constants & apply 2024 formatting #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YeungOnion merged 2 commits into from
Nov 17, 2025
Merged

fix(kde): use core instead of std constants & apply 2024 formatting #358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76c8e6
fix(fmt): apply 2024 formatting to KDE
Nov 3, 2025
c80f1b1
fix: use core instead of std in KDE
Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions src/function/kernel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
//! assert!((e.evaluate(0.0) - 0.75).abs() < 1e-12);
//! ```

use std::f64::consts::{FRAC_PI_2, PI};
use core::f64::consts::{FRAC_PI_2, PI};

/// Common interface for kernel functions used in KDE and smoothing.
pub trait Kernel {
Expand Down Expand Up @@ -66,11 +66,7 @@ pub struct Epanechnikov;
impl Kernel for Epanechnikov {
fn evaluate(&self, x: f64) -> f64 {
let a = x.abs();
if a <= 1.0 {
0.75 * (1.0 - a * a)
} else {
0.0
}
if a <= 1.0 { 0.75 * (1.0 - a * a) } else { 0.0 }
}

fn support(&self) -> Option<(f64, f64)> {
Expand All @@ -85,11 +81,7 @@ pub struct Triangular;
impl Kernel for Triangular {
fn evaluate(&self, x: f64) -> f64 {
let a = x.abs();
if a <= 1.0 {
1.0 - a
} else {
0.0
}
if a <= 1.0 { 1.0 - a } else { 0.0 }
}

fn support(&self) -> Option<(f64, f64)> {
Expand Down Expand Up @@ -143,11 +135,7 @@ pub struct Uniform;

impl Kernel for Uniform {
fn evaluate(&self, x: f64) -> f64 {
if x.abs() <= 1.0 {
0.5
} else {
0.0
}
if x.abs() <= 1.0 { 0.5 } else { 0.0 }
}

fn support(&self) -> Option<(f64, f64)> {
Expand Down
Loading