fix(kde): use core instead of std constants & apply 2024 formatting #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataziel
changed the title
nataziel
changed the title
|
Thank you for switching from std to core, that’s a subtle yet important improvement for no_std compatibility, which I forgot about. However, could you clarify why you applied the 2024 edition formatting? |
Author
|
Take a look at the cargo.toml again mate, it definitely says Was changed with this pr: #356 |
|
Ohhhh you are right, it was changed yesterday 😄 I didn't notice it, my bad ✋ |
Contributor
|
Thanks for the quick turn @nataziel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed std to core import
Applied 2024 formatting to KDE module to fix CI error