Skip to content

fix(stackable-cockpit/stacklet): Use heritage label for looking up minio #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techassi merged 2 commits into from
Mar 19, 2025
Merged

fix(stackable-cockpit/stacklet): Use heritage label for looking up minio #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9de6e0
fix(stackable-cockpit/stacklet): Use heritage label for looking up minio
NickLarsenNZ Mar 19, 2025
dfc0745
chore: Update changelog
NickLarsenNZ Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/stackable-cockpit/src/platform/stacklet/minio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub(super) async fn list(client: &Client, namespace: Option<&str>) -> Result<Vec
let mut stacklets = Vec::new();

// The helm-chart uses `app` instead of `app.kubernetes.io/app`, so we can't use `ListParams::from_product` here
let params = ListParams::default().labels("app=minio,app.kubernetes.io/managed-by=Helm");
let params = ListParams::default().labels("app=minio,heritage=Helm");
let services = client
.list_services(namespace, &params)
.await
Expand Down
2 changes: 2 additions & 0 deletions rust/stackablectl/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ All notable changes to this project will be documented in this file.
### Fixes

- Use `rustls-native-certs` so that `stackablectl` can be used in environments with internal PKI ([#351]).
- Use `heritage` label when looking up the `minio-console` stacklet ([#364]).

[#351]: https://github.com/stackabletech/stackable-cockpit/pull/351
[#364]: https://github.com/stackabletech/stackable-cockpit/pull/364

## [24.11.3] - 2025-01-27

Expand Down
Loading