fix(stackable-cockpit/stacklet): Use heritage label for looking up minio #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
Description
Due to the minio charts being pre-rendered (until they can support TLS certs mounted directly on pods instead of via a Secret mount), the labels have slightly changed.
Therefore, stackable-cockpit needs to lookup a common label.
Tip
Ideally we should have a new label that is applied to both
plainYamlandhelmChart, eg:stackable.tech/stacklet: "true"- but that is a little difficult without intercepting Helm Chart yamls.Testing
24.11.1 demo:
nightly (pre-25.3.0) demo: