fix: Revert default cluster domain to 'cluster.local'#947
Merged
Conversation
maltesander
reviewed
Jan 21, 2025
5536b0e to
b75dfc2
Compare
nightkr
reviewed
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert the change of the default cluster domain introduced by #939.
Reasoning: We came across some issues with TLS certificates and Kerberos keytabs and decided to make this behavior (FQDN domains for services/pods) opt-in for now. We still wanted to keep experimental support for it, but only if a user opts in by explicitly setting
KUBERNETES_CLUSTER_DOMAINto a domain with a trailing dot.I tested this change with Zookeeper, both with and without
KUBERNETES_CLUSTER_DOMAINset, works as expected.Definition of Done Checklist