Skip to content

Commit b75dfc2

Browse files
committed
fix: remove recommendations for trailing dot in Kubernetes cluster domain
1 parent 318c6e1 commit b75dfc2

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

crates/stackable-operator/src/utils/cluster_info.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ pub struct KubernetesClusterInfo {
1414
#[derive(clap::Parser, Debug, Default, PartialEq, Eq)]
1515
pub struct KubernetesClusterInfoOpts {
1616
/// Kubernetes cluster domain, usually this is `cluster.local`.
17-
///
18-
/// Please note that we recommend adding a trailing dot (".") to reduce DNS requests, see
19-
/// <https://github.com/stackabletech/issues/issues/656> for details.
20-
//
2117
// We are not using a default value here, as operators will probably do an more advanced
2218
// auto-detection of the cluster domain in case it is not specified in the future.
2319
#[arg(long, env)]
@@ -29,9 +25,6 @@ impl KubernetesClusterInfo {
2925
let cluster_domain = match &cluster_info_opts.kubernetes_cluster_domain {
3026
Some(cluster_domain) => {
3127
tracing::info!(%cluster_domain, "Using configured Kubernetes cluster domain");
32-
if !cluster_domain.ends_with('.') {
33-
tracing::warn!(%cluster_domain, "Your configured Kubernetes cluster domain is not fully qualified (it does not end with a dot (\".\")). We recommend adding a trailing dot to reduce DNS requests, see https://github.com/stackabletech/issues/issues/656 for details");
34-
}
3528

3629
cluster_domain.clone()
3730
}

0 commit comments

Comments
 (0)