-
-
Notifications
You must be signed in to change notification settings - Fork 9
fix(test): Iceberg/Minio on openshift #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puhhhh....
Please have a look at the linter failures and decide if we want to ignore them
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let you decide on the linting
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let you decide on the linting
Thanks! I decided to do it to keep the checks clean (and hadn't realised pre-commit was not activated locally) |
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I was not sure how much was generated content from the helm-chart
* fix(test): Iceberg/Minio on openshift * linting * more linting * more linting * linting, finally turned on pre-commit locally
fix(test): Iceberg/Minio on openshift (#827) * fix(test): Iceberg/Minio on openshift * linting * more linting * more linting * linting, finally turned on pre-commit locally
Description
Test did not work on Openshift
Tests:
Openshift:
kinD:
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker