Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Jul 18, 2025

Description

Test did not work on Openshift

Tests:

Openshift:

--- PASS: kuttl (427.90s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/iceberg_nifi-iceberg-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_hdfs-l-3.4.1_hive-l-4.0.1_trino-l-476_krb5-1.21.1_iceberg-use-kerberos-true_kerberos-realm-PROD.MYCORP_openshift-true (417.79s)
PASS

kinD:

--- PASS: kuttl (692.84s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/iceberg_nifi-iceberg-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_hdfs-l-3.4.1_hive-l-4.0.1_trino-l-476_krb5-1.21.1_iceberg-use-kerberos-false_kerberos-realm-PROD.MYCORP_openshift-false (689.56s)
        --- PASS: kuttl/harness/iceberg_nifi-iceberg-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_hdfs-l-3.4.1_hive-l-4.0.1_trino-l-476_krb5-1.21.1_iceberg-use-kerberos-true_kerberos-realm-PROD.MYCORP_openshift-false (692.20s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Jul 18, 2025
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Jul 21, 2025
sbernauer
sbernauer previously approved these changes Jul 25, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puhhhh....
Please have a look at the linter failures and decide if we want to ignore them

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 25, 2025
sbernauer
sbernauer previously approved these changes Jul 25, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you decide on the linting

sbernauer
sbernauer previously approved these changes Jul 25, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you decide on the linting

@adwk67
Copy link
Member Author

adwk67 commented Jul 25, 2025

I let you decide on the linting

Thanks! I decided to do it to keep the checks clean (and hadn't realised pre-commit was not activated locally)

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I was not sure how much was generated content from the helm-chart

@adwk67 adwk67 enabled auto-merge July 25, 2025 08:04
@adwk67 adwk67 added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit 0726965 Jul 25, 2025
17 checks passed
@adwk67 adwk67 deleted the fix/iceberg-test-minio-2 branch July 25, 2025 08:18
adwk67 added a commit that referenced this pull request Jul 25, 2025
* fix(test): Iceberg/Minio on openshift

* linting

* more linting

* more linting

* linting, finally turned on pre-commit locally
adwk67 added a commit that referenced this pull request Jul 25, 2025
fix(test): Iceberg/Minio on openshift (#827)

* fix(test): Iceberg/Minio on openshift

* linting

* more linting

* more linting

* linting, finally turned on pre-commit locally
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jul 25, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants