linting, finally turned on pre-commit locally

Author: adwk67

tests/templates/kuttl/iceberg/20_minio.yaml

@@ -33,7 +33,7 @@ data:
     set -e # Have script exit in the event of a failed command.
     MC_CONFIG_DIR="/etc/minio/mc/"
     MC="/usr/bin/mc --insecure --config-dir ${MC_CONFIG_DIR}"
-    
+
     # connectToMinio
     # Use a check-sleep-check loop to wait for MinIO service to be available
     connectToMinio() {
@@ -61,15 +61,15 @@ data:
     	set -e # reset `e` as active
     	return 0
     }
-    
+
     # checkBucketExists ($bucket)
     # Check if the bucket exists, by using the exit code of `mc ls`
     checkBucketExists() {
     	BUCKET=$1
     	CMD=$(${MC} stat myminio/$BUCKET >/dev/null 2>&1)
     	return $?
     }
-    
+
     # createBucket ($bucket, $policy, $purge)
     # Ensure bucket exists, purging if asked to
     createBucket() {
@@ -78,7 +78,7 @@ data:
     	PURGE=$3
     	VERSIONING=$4
     	OBJECTLOCKING=$5
-    
+
     	# Purge the bucket, if set & exists
     	# Since PURGE is user input, check explicitly for `true`
     	if [ $PURGE = true ]; then
@@ -91,7 +91,7 @@ data:
     			echo "Bucket '$BUCKET' does not exist, skipping purge."
     		fi
     	fi
-    
+
     	# Create the bucket if it does not exist and set objectlocking if enabled (NOTE: versioning will be not changed if OBJECTLOCKING is set because it enables versioning to the Buckets created)
     	if ! checkBucketExists $BUCKET; then
     		if [ ! -z $OBJECTLOCKING ]; then
@@ -109,7 +109,7 @@ data:
     			echo "Bucket '$BUCKET' already exists."
     		fi
     	fi
-    
+
     	# set versioning for bucket if objectlocking is disabled or not set
     	if [ $OBJECTLOCKING = false ]; then
     		if [ ! -z $VERSIONING ]; then
@@ -124,30 +124,30 @@ data:
     	else
     		echo "Bucket '$BUCKET' versioning unchanged."
     	fi
-    
+
     	# At this point, the bucket should exist, skip checking for existence
     	# Set policy on the bucket
     	echo "Setting policy of bucket '$BUCKET' to '$POLICY'."
     	${MC} anonymous set $POLICY myminio/$BUCKET
     }
-    
+
     # Try connecting to MinIO instance
     scheme=https
     connectToMinio $scheme
-    
+
     # Create the buckets
     createBucket demo "public" false false false
-    
+
   add-user: |-
     #!/bin/sh
     set -e ; # Have script exit in the event of a failed command.
     MC_CONFIG_DIR="/etc/minio/mc/"
     MC="/usr/bin/mc --insecure --config-dir ${MC_CONFIG_DIR}"
-    
+
     # AccessKey and secretkey credentials file are added to prevent shell execution errors caused by special characters.
     # Special characters for example : ',",<,>,{,}
     MINIO_ACCESSKEY_SECRETKEY_TMP="/tmp/accessKey_and_secretKey_tmp"
-    
+
     # connectToMinio
     # Use a check-sleep-check loop to wait for MinIO service to be available
     connectToMinio() {
@@ -174,14 +174,14 @@ data:
       set -e ; # reset `e` as active
       return 0
     }
-    
+
     # checkUserExists ()
     # Check if the user exists, by using the exit code of `mc admin user info`
     checkUserExists() {
       CMD=$(${MC} admin user info myminio $(head -1 $MINIO_ACCESSKEY_SECRETKEY_TMP) > /dev/null 2>&1)
       return $?
     }
-    
+
     # createUser ($policy)
     createUser() {
       POLICY=$1
@@ -205,7 +205,7 @@ data:
       fi
       #clean up credentials files.
       rm -f $MINIO_ACCESSKEY_SECRETKEY_TMP
-    
+
       # set policy for user
       if [ ! -z $POLICY -a $POLICY != " " ] ; then
           echo "Adding policy '$POLICY' for '$USER'"
@@ -216,22 +216,22 @@ data:
           echo "User '$USER' has no policy attached."
       fi
     }
-    
+
     # Try connecting to MinIO instance
     scheme=https
     connectToMinio $scheme
-    
+
     # Create the users
     echo console > $MINIO_ACCESSKEY_SECRETKEY_TMP
     echo console123 >> $MINIO_ACCESSKEY_SECRETKEY_TMP
     createUser consoleAdmin
-    
+
   add-policy: |-
     #!/bin/sh
     set -e ; # Have script exit in the event of a failed command.
     MC_CONFIG_DIR="/etc/minio/mc/"
     MC="/usr/bin/mc --insecure --config-dir ${MC_CONFIG_DIR}"
-    
+
     # connectToMinio
     # Use a check-sleep-check loop to wait for MinIO service to be available
     connectToMinio() {
@@ -258,20 +258,20 @@ data:
       set -e ; # reset `e` as active
       return 0
     }
-    
+
     # checkPolicyExists ($policy)
     # Check if the policy exists, by using the exit code of `mc admin policy info`
     checkPolicyExists() {
       POLICY=$1
       CMD=$(${MC} admin policy info myminio $POLICY > /dev/null 2>&1)
       return $?
     }
-    
+
     # createPolicy($name, $filename)
     createPolicy () {
       NAME=$1
       FILENAME=$2
-    
+
       # Create the name if it does not exist
       echo "Checking policy: $NAME (in /config/$FILENAME.json)"
       if ! checkPolicyExists $NAME ; then
@@ -280,23 +280,23 @@ data:
         echo "Policy '$NAME' already exists."
       fi
       ${MC} admin policy create myminio $NAME /config/$FILENAME.json
-    
+
     }
-    
+
     # Try connecting to MinIO instance
     scheme=https
     connectToMinio $scheme
-    
+
   add-svcacct: |-
     #!/bin/sh
     set -e ; # Have script exit in the event of a failed command.
     MC_CONFIG_DIR="/etc/minio/mc/"
     MC="/usr/bin/mc --insecure --config-dir ${MC_CONFIG_DIR}"
-    
+
     # AccessKey and secretkey credentials file are added to prevent shell execution errors caused by special characters.
     # Special characters for example : ',",<,>,{,}
     MINIO_ACCESSKEY_SECRETKEY_TMP="/tmp/accessKey_and_secretKey_svcacct_tmp"
-    
+
     # connectToMinio
     # Use a check-sleep-check loop to wait for MinIO service to be available
     connectToMinio() {
@@ -323,14 +323,14 @@ data:
       set -e ; # reset `e` as active
       return 0
     }
-    
+
     # checkSvcacctExists ()
     # Check if the svcacct exists, by using the exit code of `mc admin user svcacct info`
     checkSvcacctExists() {
       CMD=$(${MC} admin user svcacct info myminio $(head -1 $MINIO_ACCESSKEY_SECRETKEY_TMP) > /dev/null 2>&1)
       return $?
     }
-    
+
     # createSvcacct ($user)
     createSvcacct () {
       USER=$1
@@ -361,17 +361,17 @@ data:
       #clean up credentials files.
       rm -f $MINIO_ACCESSKEY_SECRETKEY_TMP
     }
-    
+
     # Try connecting to MinIO instance
     scheme=https
     connectToMinio $scheme
-    
+
   custom-command: |-
     #!/bin/sh
     set -e ; # Have script exit in the event of a failed command.
     MC_CONFIG_DIR="/etc/minio/mc/"
     MC="/usr/bin/mc --insecure --config-dir ${MC_CONFIG_DIR}"
-    
+
     # connectToMinio
     # Use a check-sleep-check loop to wait for MinIO service to be available
     connectToMinio() {
@@ -398,14 +398,14 @@ data:
       set -e ; # reset `e` as active
       return 0
     }
-    
+
     # runCommand ($@)
     # Run custom mc command
     runCommand() {
       ${MC} "$@"
       return $?
     }
-    
+
     # Try connecting to MinIO instance
     scheme=https
     connectToMinio $scheme
@@ -523,7 +523,7 @@ spec:
               mountPath: "/tmp/credentials"
               readOnly: true
             - name: export
-              mountPath: /export            
+              mountPath: /export
             - mountPath: /etc/minio/original_certs
               name: tls
             - mountPath: /etc/minio/certs
@@ -550,15 +550,15 @@ spec:
             requests:
               cpu: 1
               memory: 2Gi
-          securityContext: 
-            readOnlyRootFilesystem: false      
+          securityContext:
+            readOnlyRootFilesystem: false
       volumes:
         - name: export
           persistentVolumeClaim:
             claimName: minio
         - name: minio-user
           secret:
-            secretName: minio        
+            secretName: minio
         - ephemeral:
             volumeClaimTemplate:
               metadata:

tests/templates/kuttl/iceberg/21_minio_jobs.yaml

@@ -19,7 +19,7 @@ spec:
         release: minio
         stackable.tech/vendor: Stackable
     spec:
-      restartPolicy: OnFailure      
+      restartPolicy: OnFailure
       volumes:
         - name: etc-path
           emptyDir: {}