refactor(frontend): align Settings "Teams" wording to "Server Edition" (MCP-1087)#626
Merged
Merged
Conversation
The server-edition Settings surface used legacy "Teams" wording (the tab label and the "Teams / Server" section heading). Align it to "Server Edition" to match the edition identity (`/api/v1/status` edition === "server"), which the frontend already keys off. Extract the section into SERVER_EDITION_FIELDS + label constants in settings/fields.ts and add a vitest guard. The config dot-paths stay on the legacy `teams.*` key on purpose: the backend config-key rename (`teams` -> `server_edition`, MCP-1085 / PR #607) is not merged, so a live config is still `teams`-keyed. Flipping the keys early would make `hasTeams` read `state.working.server_edition` and silently hide the whole tab. The key switch is tracked as a follow-up blocked by that backend change. Related MCP-1087
Deploying mcpproxy-docs with
|
| Latest commit: |
822b286
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea1af958.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://mcp-1087-frontend-server-edi.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 27189187913 --repo smart-mcp-proxy/mcpproxy-go
|
![mcpproxy-gatekeeper[bot]](https://avatars.githubusercontent.com/u/216428285?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Gatekeeper approval — Codex review verdict: ACCEPT.
This approval is posted automatically by the MCPProxy Gatekeeper App on behalf of the Codex reviewer (verdict of record lives in the Paperclip review thread). Author≠approver satisfied; QA + CI gates enforced separately.
Auto-approved per Model B (MCP-1249).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the legacy "Teams" wording on the server-edition Settings surface with "Server Edition":
Teams→Server Edition👥 Teams / Server→👥 Server EditionThe section/labels are extracted into
SERVER_EDITION_FIELDS+SERVER_EDITION_TAB_LABEL/SERVER_EDITION_SECTION_TITLEconstants inviews/settings/fields.ts(alongside the existingSECURITY_FIELDS/GENERAL_FIELDS), with a vitest guard.Scope decision — config keys stay
teams.*(deliberate)This was "blocked by backend A" (the
teams→server_editionconfig-key rename, MCP-1085 / PR #607). That PR is closed / unmerged, so on livemainthe config is stillteams-keyed and/api/v1/statusalready reportsedition: "server"(the frontend'sisTeamsEditionalready checks=== 'server', unchanged).Therefore this PR ships only the backend-independent part — user-facing wording — and keeps the form's config dot-paths on
teams.*to match the live contract. Flipping them toserver_edition.*now would makehasTeamsreadstate.working.server_edition, which a liveteams-keyed config doesn't have → the whole server-edition tab silently disappears. The key switch is tracked as a follow-up blocked by the backend rename.Verification (artifacts kept local per issue)
make build✅ (frontend embedded into the Go binary; confirmed bundle contains "Server Edition", no "Teams / Server")npm run type-check✅settings-server-edition-wording.spec.ts)teamsconfig block; tab + heading read "Server Edition", no\bTeams\btext; form fields render and save correctly (config keys still writeteams.*).Related MCP-1087