fix: disable upgrade notification for the manifest info command

internal/update/update.go

@@ -19,11 +19,11 @@ import (
 	"net/http"
 	"os"
 	"reflect"
+	"strings"
 	"sync"
 	"time"
 
 	"github.com/slackapi/slack-cli/internal/api"
-	"github.com/slackapi/slack-cli/internal/goutils"
 	"github.com/slackapi/slack-cli/internal/shared"
 	"github.com/slackapi/slack-cli/internal/slackerror"
 	"github.com/spf13/cobra"
@@ -223,13 +223,17 @@ func (u *UpdateNotification) isCI() bool {
 
 // isIgnoredCommand returns true when the process is in the list of commands.
 func (u *UpdateNotification) isIgnoredCommand() bool {
-	ignoredCommands := []string{"_fingerprint", "api", "version"}
-	osStr := os.Args[0:]
-	if len(osStr) < 2 {
+	ignoredCommands := []string{"_fingerprint", "api", "manifest info", "version"}
+	if len(os.Args) < 2 {
 		return false
 	}
-	commandName := osStr[1]
-	return goutils.Contains(ignoredCommands, commandName, true)
+	commandStr := strings.Join(os.Args[1:], " ")
+	for _, ignored := range ignoredCommands {
+		if commandStr == ignored || strings.HasPrefix(commandStr, ignored+" ") {
+			return true
+		}
+	}
+	return false
 }
 
 // isLastUpdateCheckedAtGreaterThan returns true when the time since the last update check is greater

internal/update/update_test.go

@@ -17,6 +17,7 @@ package update
 import (
 	"context"
 	"os"
+	"strings"
 	"testing"
 
 	"github.com/slackapi/slack-cli/internal/config"
@@ -165,14 +166,22 @@ func Test_UpdateNotification_isIgnoredCommand(t *testing.T) {
 			command:  "version",
 			expected: true,
 		},
+		"manifest info command": {
+			command:  "manifest info",
+			expected: true,
+		},
+		"manifest validate command": {
+			command:  "manifest validate",
+			expected: false,
+		},
 		"auth command": {
 			command:  "auth",
 			expected: false,
 		},
 	} {
 		t.Run(name, func(t *testing.T) {
 			if tc.command != "" {
-				os.Args = []string{"placeholder", tc.command}
+				os.Args = append([]string{"placeholder"}, strings.Split(tc.command, " ")...)
 			} else {
 				os.Args = []string{"placeholder"}
 			}