fix: disable upgrade notification for the manifest info command#548
Open
mwbrooks wants to merge 1 commit into
Open
fix: disable upgrade notification for the manifest info command#548mwbrooks wants to merge 1 commit into
mwbrooks wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 71.64% 71.66% +0.01%
==========================================
Files 225 225
Lines 19066 19068 +2
==========================================
+ Hits 13660 13665 +5
+ Misses 4202 4199 -3
Partials 1204 1204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
approved these changes
May 15, 2026
| ignoredCommands := []string{"_fingerprint", "api", "version"} | ||
| osStr := os.Args[0:] | ||
| if len(osStr) < 2 { | ||
| ignoredCommands := []string{"_fingerprint", "api", "manifest info", "version"} |
Member
There was a problem hiding this comment.
Suggested change
| ignoredCommands := []string{"_fingerprint", "api", "manifest info", "version"} | |
| ignoredCommands := []string{"_fingerprint", "api", "manifest", "manifest info", "version"} |
🪬 question: Is the shortened command automatic? I prefer extended commands often in scripts but am unsure if this should be covered too.
| }, | ||
| "manifest validate command": { | ||
| command: "manifest validate", | ||
| expected: false, |
Member
There was a problem hiding this comment.
👁️🗨️ praise: Thanks! This makes me think much about tests as spec more than unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request adds
manifest infoto the list of commands that suppress update notifications. Themanifest infocommand outputs structured data consumed by other tools, so injecting an upgrade banner would corrupt the output.Also extends
isIgnoredCommand()to support multi-word subcommands (e.g.,manifest infois ignored butmanifest validateis not).Preview
N/A
Testing
go build -ldflags="-X 'github.com/slackapi/slack-cli/internal/version.Version=v1.0.0'" -o bin/slacklastUpdateCheckedAttimestamp from~/.slack/config.jsonso the check isn't skipped due to recency../bin/slack create my-app/ cd my-app/slack manifest infodoes NOT show an upgrade notification:./bin/slack manifest info --source localRequirements