Skip to content

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Jan 29, 2026

Summary

Related to PR #315

This pull request standardizes the naming convention in table-driven tests that use the map pattern across the codebase.

  • Standardizes on name and tc (test case) in all table-driven tests using the slice pattern
  • Some common patterns you'll see in this PR:
    • for name, tt := rangefor name, tc := range
    • for ttName, tt := rangefor name, tc := range
    • for name, test := rangefor name, tc := range
    • for name, s := rangefor name, tc := range

Motivation

This is the second step in refactoring all of our Table Tests to use a consistent style. It creates consistent naming between our Slice and Map Pattern table tests.

The next PR will refactor all simple Slice Pattern tests to Map Pattern.

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Jan 29, 2026
@mwbrooks mwbrooks self-assigned this Jan 29, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.63%. Comparing base (14fe964) to head (7fcc775).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   64.62%   64.63%           
=======================================
  Files         212      212           
  Lines       17755    17755           
=======================================
+ Hits        11475    11476    +1     
  Misses       5205     5205           
+ Partials     1075     1074    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review January 29, 2026 23:26
@mwbrooks mwbrooks requested a review from a team as a code owner January 29, 2026 23:26
@zimeg zimeg modified the milestones: v3.12.0, Next Release Jan 31, 2026
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks LGTM! The tests are passing still so let's merge this 🧪 ✨

@zimeg zimeg enabled auto-merge (squash) January 31, 2026 01:17
@mwbrooks
Copy link
Member Author

@zimeg Thanks for tackling this monster number of line changes! 😬 🙇🏻 🙇🏻‍♂️ 🙇🏻‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants