-
Notifications
You must be signed in to change notification settings - Fork 27
refactor(tests): use consistent naming in table tests with the map pattern #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): use consistent naming in table tests with the map pattern #316
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 64.62% 64.63%
=======================================
Files 212 212
Lines 17755 17755
=======================================
+ Hits 11475 11476 +1
Misses 5205 5205
+ Partials 1075 1074 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks LGTM! The tests are passing still so let's merge this 🧪 ✨
|
@zimeg Thanks for tackling this monster number of line changes! 😬 🙇🏻 🙇🏻♂️ 🙇🏻♀️ |
Summary
Related to PR #315
This pull request standardizes the naming convention in table-driven tests that use the map pattern across the codebase.
nameandtc(test case) in all table-driven tests using the slice patternfor name, tt := range→for name, tc := rangefor ttName, tt := range→for name, tc := rangefor name, test := range→for name, tc := rangefor name, s := range→for name, tc := rangeMotivation
This is the second step in refactoring all of our Table Tests to use a consistent style. It creates consistent naming between our Slice and Map Pattern table tests.
The next PR will refactor all simple Slice Pattern tests to Map Pattern.
Requirements