-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(search-modal): add quick navigation items and fix cmdk value uniqueness #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryEnhanced the search modal by adding three new quick navigation items (Knowledge Base, Help, and Settings) and fixing cmdk value uniqueness issues. The changes improve user experience by providing more navigation shortcuts and resolve potential conflicts in command palette selection by prefixing all item values with their type (e.g., Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant SearchModal
participant Router
participant SettingsModal
participant HelpModal
User->>SearchModal: Opens search modal (⌘K)
User->>SearchModal: Types search query
SearchModal->>SearchModal: Filters items with customFilter
Note over SearchModal: Prefixed values ensure uniqueness<br/>(block-, tool-, trigger-, workflow-, etc.)
alt Navigate to page with href
User->>SearchModal: Selects "Knowledge Base"
SearchModal->>Router: router.push(/workspace/[id]/knowledge)
SearchModal->>User: Closes modal
end
alt Trigger modal with onClick
User->>SearchModal: Selects "Settings" (⌘,)
SearchModal->>SettingsModal: openSettingsModal()
SearchModal->>User: Closes modal
end
alt Trigger help modal
User->>SearchModal: Selects "Help"
SearchModal->>HelpModal: window.dispatchEvent('open-help-modal')
SearchModal->>User: Closes modal
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary
Type of Change
Testing
Tested manually
Checklist