ci: monthly Cranelift release branch automation regex#1665
Open
0xmuon wants to merge 2 commits into
Open
Conversation
0xmuon
commented
Jun 8, 2026
|
|
||
| - name: Patch Cargo.toml to use release branch Cranelift | ||
| run: | | ||
| sed -i -E 's/"0\.13[0-9]\.[0-9]+"/"*"/g' Cargo.toml |
Contributor
Author
There was a problem hiding this comment.
I used 0\.13[0-9]\.[0-9]+ here to safely target the current0.13x.xseries and restrict the blast radius. Would you prefer I update this to a fully future-proof regex like 0\.[0-9]+\.[0-9]+ so it automatically handles the jump to 0.140.0 and beyond without breaking?
Contributor
Author
There was a problem hiding this comment.
There is no point to update it to [0-9]\.[0-9]+\.[0-9]+ , as cranelift version numbering so far doesn't demand it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #1663
Previously, Cargo was ignoring the patch because of strict
0.a.bversion mismatches between theCargo.tomllock and new release branch. I added asedstep to temporarily replace the hardcoded Cranelift versions with a*during the CI run so Cargo accepts the patch.