Skip to content

ci: monthly Cranelift release branch automation regex #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xmuon wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

ci: monthly Cranelift release branch automation regex #1665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0cfa39
fix cranelift patch rejection by relaxing SemVer requirements
0xmuon Jun 8, 2026
fbdb472
fix cranelift patch rejection by relaxing version hardcoding
0xmuon Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/cranelift-release-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:

- name: Patch Cargo.toml to use release branch Cranelift
run: |
sed -i -E 's/"0\.13[0-9]\.[0-9]+"/"*"/g' Cargo.toml

@0xmuon 0xmuon Jun 8, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used 0\.13[0-9]\.[0-9]+ here to safely target the current0.13x.xseries and restrict the blast radius. Would you prefer I update this to a fully future-proof regex like 0\.[0-9]+\.[0-9]+ so it automatically handles the jump to 0.140.0 and beyond without breaking?

View changes since the review

@0xmuon 0xmuon Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point to update it to [0-9]\.[0-9]+\.[0-9]+ , as cranelift version numbering so far doesn't demand it.


cat >>Cargo.toml <<EOF
[patch.crates-io]
cranelift-codegen = { git = "https://github.com/bytecodealliance/wasmtime.git", branch = "$(echo $WASMTIME_RELEASE_BRANCH)" }
Expand All @@ -47,7 +49,8 @@ jobs:
cranelift-jit = { git = "https://github.com/bytecodealliance/wasmtime.git", branch = "$(echo $WASMTIME_RELEASE_BRANCH)" }
cranelift-object = { git = "https://github.com/bytecodealliance/wasmtime.git", branch = "$(echo $WASMTIME_RELEASE_BRANCH)" }
EOF
cargo check -p rustc-hash # update lockfile

cargo update
env:
WASMTIME_RELEASE_BRANCH: ${{ steps.wasmtime_release_branch.outputs.branch }}

Expand Down
Loading