Skip to content

HOLD: Fix Safari compatibility for share search URL feature #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

HOLD: Fix Safari compatibility for share search URL feature #1018

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b647fd
Initial plan
Copilot Feb 15, 2026
c4cf1c2
Fix Safari compatibility for share search URL feature
Copilot Feb 15, 2026
8a00066
Improve value check to only exclude empty strings
Copilot Feb 15, 2026
1b828d2
Add missing semicolon for code style consistency
Copilot Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions app/frontend/javascript/controllers/share_url_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,21 @@ export default class extends Controller {

// Build URL from form data
const form = this.element;
const params = new URLSearchParams(new FormData(form)).toString();
const shareUrl = `${form.action}?${params}`;
const formData = new FormData(form);
const params = new URLSearchParams();

// Manually add each form field to URLSearchParams for Safari compatibility
for (const [key, value] of formData.entries()) {
// Include all values except empty strings to keep URLs clean
if (value !== '') {
params.append(key, value);
}
}

const shareUrl = `${form.action}?${params.toString()}`;

this.outputTarget.value = shareUrl;
this.outputTarget.classList.remove("hidden")
this.outputTarget.classList.remove("hidden");

navigator.clipboard.writeText(shareUrl).then(() => {
alert("Search URL copied to clipboard!");
Expand Down