HOLD: Fix Safari compatibility for share search URL feature

[Copilot]

What is the goal of this PR and why is this important?

The "Share this search" feature was not working properly in Safari browsers. When users clicked the "Share this search" button and pasted the URL into another browser window (particularly Safari), the search parameters were not being preserved, resulting in different or no search results.

How did you approach the change?

The root cause was Safari's incomplete support for constructing URLSearchParams directly from FormData using the syntax new URLSearchParams(new FormData(form)).

Changed the implementation in app/frontend/javascript/controllers/share_url_controller.js to:

• Manually iterate through FormData entries
• Add each non-empty value to URLSearchParams individually
• Filter out empty strings to keep URLs clean while preserving valid falsy values (0, false)
• This approach works across all browsers including Safari

Anything else to add?

• ✅ CodeQL security analysis passed with no issues
• ✅ Code style consistency maintained
• The fix is minimal and surgical, only affecting the URL construction logic in the share-url Stimulus controller

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[maebeale]

@copilot try again

[Copilot]

@copilot try again

Fixed the Safari compatibility issue with the "Share this search" feature. The problem was that Safari doesn't support constructing URLSearchParams directly from FormData. Changed to manually iterate through form fields, which works across all browsers. Commits: 1b828d2