Skip to content

fix: compatible with Rsbuild v2 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Feb 28, 2026
+261 −119
Merged

fix: compatible with Rsbuild v2 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ node_modules
dist/
test-results

# Test
test-temp-*

# IDE
.vscode/*
!.vscode/settings.json
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
"devDependencies": {
"@biomejs/biome": "^1.9.4",
"@playwright/test": "^1.57.0",
"@rsbuild/core": "^1.6.10",
"@rsbuild/plugin-less": "^1.5.0",
"@rsbuild/plugin-sass": "^1.4.0",
"@rsbuild/plugin-stylus": "^1.2.0",
"@rsbuild/core": "^2.0.0-beta.4",
"@rsbuild/plugin-less": "^1.6.0",
"@rsbuild/plugin-sass": "^1.5.0",
"@rsbuild/plugin-stylus": "^1.3.0",
Comment on lines +38 to +41
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsbuild/core@2.x requires Node ^20.19.0 || >=22.12.0 (per the lockfile). If contributors run pnpm install on older Node versions they’ll hit hard engine errors; consider documenting the required Node version for development (or adding an engines/tooling hint) alongside the devDependency upgrade.

Copilot uses AI. Check for mistakes.
"@rsbuild/plugin-type-check": "^1.3.1",
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsbuild/plugin-type-check@1.3.1 declares a peer dependency on @rsbuild/core 1.x (see pnpm-lock.yaml), but this PR upgrades the workspace dev dependency to @rsbuild/core 2.x. This will produce unmet peer dependency warnings and may indicate real incompatibility; consider upgrading @rsbuild/plugin-type-check to a release that supports Rsbuild v2 or removing it if it’s not used in this repo.

Suggested change
"@rsbuild/plugin-type-check": "^1.3.1",
"@rsbuild/plugin-type-check": "^2.0.0-0",

Copilot uses AI. Check for mistakes.
"@rslib/core": "^0.18.2",
"@types/node": "^22.19.1",
Expand Down
Loading