Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's build system to be compatible with Rsbuild v2. It involves updating the primary Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates @rsbuild/core and its related dependencies to version 2 to ensure compatibility. The changes primarily involve dependency version bumps and a small logic adjustment in src/index.ts to accommodate API differences in Rsbuild v2. The changes look good, but I have one suggestion to improve the readability of the new compatibility logic.
There was a problem hiding this comment.
Pull request overview
Updates this plugin’s development dependencies and bundler-chain integration to work with Rsbuild v2 while retaining compatibility with Rsbuild v1.
Changes:
- Upgraded
@rsbuild/coreto the2.0.0-betaline and bumped related@rsbuild/plugin-*dev dependencies. - Adjusted bundler-chain rule selection in
pluginTypedCSSModulesto handle Rsbuild v2’s rule structure. - Updated lockfile and ignored temporary test directories.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/index.ts |
Adds Rsbuild v1/v2 branching when selecting the CSS rule to inject the typed CSS modules loader. |
package.json |
Bumps Rsbuild-related devDependencies to versions compatible with Rsbuild v2 betas. |
pnpm-lock.yaml |
Captures the resolved Rsbuild/Rspack beta dependency graph and related upgrades. |
.gitignore |
Ignores test-temp-* directories created by tests. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@rsbuild/core": "^2.0.0-beta.4", | ||
| "@rsbuild/plugin-less": "^1.6.0", | ||
| "@rsbuild/plugin-sass": "^1.5.0", | ||
| "@rsbuild/plugin-stylus": "^1.3.0", |
There was a problem hiding this comment.
@rsbuild/core@2.x requires Node ^20.19.0 || >=22.12.0 (per the lockfile). If contributors run pnpm install on older Node versions they’ll hit hard engine errors; consider documenting the required Node version for development (or adding an engines/tooling hint) alongside the devDependency upgrade.
| "@rsbuild/plugin-less": "^1.6.0", | ||
| "@rsbuild/plugin-sass": "^1.5.0", | ||
| "@rsbuild/plugin-stylus": "^1.3.0", | ||
| "@rsbuild/plugin-type-check": "^1.3.1", |
There was a problem hiding this comment.
@rsbuild/plugin-type-check@1.3.1 declares a peer dependency on @rsbuild/core 1.x (see pnpm-lock.yaml), but this PR upgrades the workspace dev dependency to @rsbuild/core 2.x. This will produce unmet peer dependency warnings and may indicate real incompatibility; consider upgrading @rsbuild/plugin-type-check to a release that supports Rsbuild v2 or removing it if it’s not used in this repo.
| "@rsbuild/plugin-type-check": "^1.3.1", | |
| "@rsbuild/plugin-type-check": "^2.0.0-0", |
@rsbuild/corefrom version 1.6.10 to 2.0.0-beta.4