Skip to content

fix: update peerDependencies to support Rsbuild v2 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jan 15, 2026
Merged

fix: update peerDependencies to support Rsbuild v2 #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"typescript": "^5.9.3"
},
"peerDependencies": {
"@rsbuild/core": "^1.7.0-beta.0 || ^1.7.0"
"@rsbuild/core": "^1.7.0 || ^2.0.0-0"
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md still only references @rsbuild/core >= 1.7.0 in the installation instructions (line 25). The documentation should be updated to mention that this version also supports Rsbuild v2, or the installation instructions should specify the version range more clearly to reflect the new peerDependencies.

Suggested change
"@rsbuild/core": "^1.7.0 || ^2.0.0-0"
"@rsbuild/core": ">=1.7.0"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests verifying compatibility with Rsbuild v2. The existing test in test/basic/index.test.ts uses a devDependency on v1.7.0-beta.0. Consider adding tests or updating the devDependency to verify the plugin works correctly with Rsbuild v2.

Copilot uses AI. Check for mistakes.
},
"peerDependenciesMeta": {
"@rsbuild/core": {
Expand Down