fix: update peerDependencies to support Rsbuild v2 #38
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the peerDependencies specification for @rsbuild/core to support Rsbuild v2 by adding ^2.0.0-0 to the version range. The change allows the plugin to work with both Rsbuild v1.7.0 and above, as well as all v2 pre-release and stable versions.
Changes:
- Updated
@rsbuild/corepeerDependencies version range to support both v1.7.0+ and v2.0.0+
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "peerDependencies": { | ||
| "@rsbuild/core": "^1.7.0-beta.0 || ^1.7.0" | ||
| "@rsbuild/core": "^1.7.0 || ^2.0.0-0" |
There was a problem hiding this comment.
The README.md still only references @rsbuild/core >= 1.7.0 in the installation instructions (line 25). The documentation should be updated to mention that this version also supports Rsbuild v2, or the installation instructions should specify the version range more clearly to reflect the new peerDependencies.
| "@rsbuild/core": "^1.7.0 || ^2.0.0-0" | |
| "@rsbuild/core": ">=1.7.0" |
| }, | ||
| "peerDependencies": { | ||
| "@rsbuild/core": "^1.7.0-beta.0 || ^1.7.0" | ||
| "@rsbuild/core": "^1.7.0 || ^2.0.0-0" |
There was a problem hiding this comment.
There are no tests verifying compatibility with Rsbuild v2. The existing test in test/basic/index.test.ts uses a devDependency on v1.7.0-beta.0. Consider adding tests or updating the devDependency to verify the plugin works correctly with Rsbuild v2.
No description provided.