[RF] Ensure RooHistPdf values are positive in RooHistPdf::doEval()#21161
Merged
guitargeek merged 2 commits intoroot-project:masterfrom Feb 6, 2026
Merged
[RF] Ensure RooHistPdf values are positive in RooHistPdf::doEval()#21161guitargeek merged 2 commits intoroot-project:masterfrom
RooHistPdf::doEval()#21161guitargeek merged 2 commits intoroot-project:masterfrom
Conversation
This is to be consistent with the old `RooHistPdf::evaluate()` code path. Closes root-project#21159, where floating point precision effects made the value fluctuate slightly below zero, resulting in NaN values when the RooFFTConvPdf (which internally uses a `RooHistPdf` to cache values) is used in a `RooAbsPdf`. Closes root-project#21159.
Test Results 22 files 22 suites 3d 14h 25m 2s ⏱️ For more details on these failures, see this check. Results for commit b9e5300. ♻️ This comment has been updated with latest results. |
lmoneta
approved these changes
Feb 6, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thank you Jonas for fixing this!
Contributor
Author
|
/backport to 6.38, 6.36 |
Contributor
Author
|
backport to 6.38, 6.36 |
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to be consistent with the old
RooHistPdf::evaluate()codepath.
Closes #21159, where floating point precision effects made the value
fluctuate slightly below zero, resulting in NaN values when the
RooFFTConvPdf (which internally uses a
RooHistPdfto cache values) isused in a
RooAbsPdf.Closes #21159.