[v638][RF] Ensure RooHistPdf values are positive in RooHistPdf::doEval()#21174
Merged
guitargeek merged 2 commits intoroot-project:v6-38-00-patchesfrom Feb 6, 2026
Merged
[v638][RF] Ensure RooHistPdf values are positive in RooHistPdf::doEval()#21174guitargeek merged 2 commits intoroot-project:v6-38-00-patchesfrom
RooHistPdf::doEval()#21174guitargeek merged 2 commits intoroot-project:v6-38-00-patchesfrom
Conversation
This is to be consistent with the old `RooHistPdf::evaluate()` code path. Closes root-project#21159, where floating point precision effects made the value fluctuate slightly below zero, resulting in NaN values when the RooFFTConvPdf (which internally uses a `RooHistPdf` to cache values) is used in a `RooAbsPdf`. Closes root-project#21159. (cherry picked from commit c948c65)
(cherry picked from commit c530a54)
Test Results 15 files 15 suites 2d 17h 17m 44s ⏱️ For more details on these failures, see this check. Results for commit 46e283f. |
guitargeek
merged commit 817dd98
into
root-project:v6-38-00-patches
21 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21161