Skip to content

Conversation

@silverweed
Copy link
Contributor

@silverweed silverweed commented Feb 3, 2026

Now both the Reader and Writer's context objects will close the underlying file upon __exit__. The object will raise an exception if accessed after the with statement.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test Results

    21 files  ±  0      21 suites  ±0   3d 11h 54m 13s ⏱️ + 7h 10m 4s
 3 779 tests +  4   3 778 ✅ +  3  0 💤 ±0  1 ❌ +1 
72 662 runs  +346  72 661 ✅ +345  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit b1b0ce6. ± Comparison against base commit 34efbdb.

♻️ This comment has been updated with latest results.

Now both the Reader and Writer's context objects will close the underlying
file upon __exit__. The object will raise an exception if accessed after
the `with` statement.
@silverweed silverweed force-pushed the rntuplereader_close_py branch from 9d678bf to a9b7af0 Compare February 5, 2026 09:25
@silverweed silverweed force-pushed the rntuplereader_close_py branch from a9b7af0 to b1b0ce6 Compare February 6, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants