Shutdown the runner VM if startup fails #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravwojdyla
approved these changes
Apr 8, 2025
Collaborator
|
👋 @jder looks great!! thank you |
ravwojdyla
reviewed
Apr 8, 2025
| echo ❌ Machine setup failed so deleting $VM_ID in ${machine_zone} ... | ||
| ${shutdown_command} | ||
| } | ||
| trap shutdown EXIT |
Collaborator
There was a problem hiding this comment.
@jder actually - wouldn't this run the shutdown as soon as the startup script finish - even if there was no problem?
Collaborator
Contributor
Author
There was a problem hiding this comment.
Yeah, sorry, I was too focused on testing the failure case :) This makes more sense. Thanks!
Collaborator
There was a problem hiding this comment.
@jder no problem, btw our CI
did not catch this because it's too quick (it's just anecho) - it was able to finish before the VM was shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some cases when machines were not shutting themselves down after running a job. When
installdependencies.shfails, this was previously skipping thecat <<-EOF > /etc/systemd/system/shutdown.shline in the startup script, which caused the shutdown service to fail rather than deleting the instance.This PR changes the behavior so that any failure in the startup script will instead cause the instance to get deleted. (It also adds
set -eto the startup script to make debugging a bit easier, but happy to revert that piece if you like.)