Shutdown timeout on error for debugging #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravwojdyla
approved these changes
Apr 8, 2025
Collaborator
ravwojdyla
left a comment
ravwojdyla
left a comment
There was a problem hiding this comment.
lgtm! I will wait for you to respond to the question. Also could you please rebase, I've fixed the pre-commit in the main via #62
jder
force-pushed
the
u/jder/timeout-for-failure
branch
from
5166d83 to
6fa4b11
Compare
ravwojdyla
approved these changes
Apr 9, 2025
Collaborator
|
@jder thank you 🙇 Would you want another release - or are you fine using |
Contributor
Author
|
Thanks, we have a fork I can update to main, so no need for a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #60 which makes it a bit easier to debug failures in startup by not immediately deleting the machine.