Skip to content

feat(DOC-1970): add missing rpk connect reference pages#1608

Open
mfernest wants to merge 3 commits intomainfrom
fix/doc-1970-rpk-connect-reference
Open

feat(DOC-1970): add missing rpk connect reference pages#1608
mfernest wants to merge 3 commits intomainfrom
fix/doc-1970-rpk-connect-reference

Conversation

@mfernest
Copy link
Contributor

Summary

Adds documentation for three rpk connect commands missing from the reference:

  • rpk connect agent (+ agent init, agent run subcommands) — marked EXPERIMENTAL
  • rpk connect dry-run
  • rpk connect plugin (+ plugin init subcommand) — marked EXPERIMENTAL

Updates nav.adoc to include the new pages in alphabetical order alongside existing rpk connect entries.

Test plan

  • Build passes locally (exit 0)
  • Netlify deploy preview renders new pages correctly
  • New pages appear in nav under rpk connect

🤖 Generated with Claude Code

Adds documentation for three rpk connect commands missing from the
reference:
- rpk connect agent (+ agent init, agent run subcommands) — EXPERIMENTAL
- rpk connect dry-run
- rpk connect plugin (+ plugin init subcommand) — EXPERIMENTAL

Updates nav.adoc to include the new pages in alphabetical order.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mfernest mfernest requested a review from a team as a code owner March 16, 2026 21:34
@netlify
Copy link

netlify bot commented Mar 16, 2026

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit c185e88
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/69bb014f9e083300084bddb3
😎 Deploy Preview https://deploy-preview-1608--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2688476c-bb84-4d08-b82c-8f6035844f98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This pull request adds documentation for new rpk connect subcommands, introducing six new AsciiDoc documentation pages for agent, agent-init, agent-run, dry-run, plugin, and plugin-init commands. The navigation structure in nav.adoc is updated to include these new command entries under a reorganized hierarchy. Previous mcp-server entries are removed from the navigation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • redpanda-data/docs#1360: Updates rpk connect documentation with mcp-server command entries that this PR reorganizes and relocates within the navigation hierarchy.

Suggested reviewers

  • JakeSCahill
  • paulohtb6
  • r-vasquez
  • kbatuigas
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is mostly complete but deviates from the template structure; it lacks the Jira link and page preview sections that are specified in the repository template. Add the required Jira ticket link (Resolves https://redpandadata.atlassian.net/browse/DOC-1970) and include page preview links from the Netlify bot to match the template format.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding missing rpk connect reference documentation pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/doc-1970-rpk-connect-reference
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (3)
modules/reference/pages/rpk/rpk-connect/rpk-connect-plugin.adoc (1)

17-17: Use empty brackets in xref to auto-pull the target page title.

The xref link includes hard-coded link text [init]. Per repository conventions, use empty brackets [] to automatically pull the title from the referenced document.

📝 Suggested change
-* xref:rpk/rpk-connect/rpk-connect-plugin-init.adoc[init]: Create the boilerplate for a custom component plugin.
+* xref:rpk/rpk-connect/rpk-connect-plugin-init.adoc[]: Create the boilerplate for a custom component plugin.

Based on learnings: "AsciiDoc linking: prefer using xref links with empty brackets (e.g., xref:section/target.adoc[]) because the title is pulled from the referenced document automatically."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/reference/pages/rpk/rpk-connect/rpk-connect-plugin.adoc` at line 17,
Replace the hard-coded xref text `[init]` with empty brackets `[]` so the link
auto-pulls the target page title; update the xref in the rpk-connect-plugin.adoc
line referencing rpk-connect-plugin-init.adoc
(xref:rpk/rpk-connect/rpk-connect-plugin-init.adoc[]).
modules/reference/pages/rpk/rpk-connect/rpk-connect-agent.adoc (2)

17-18: Use empty brackets in xrefs to auto-pull target page titles.

The xref links include hard-coded link text. Per repository conventions, use empty brackets [] to automatically pull titles from the referenced documents.

📝 Suggested change
-* xref:rpk/rpk-connect/rpk-connect-agent-init.adoc[init]: Initialize a Redpanda Connect agent.
-* xref:rpk/rpk-connect/rpk-connect-agent-run.adoc[run]: Execute a Redpanda Connect agent as part of a pipeline with MCP tool access.
+* xref:rpk/rpk-connect/rpk-connect-agent-init.adoc[]: Initialize a Redpanda Connect agent.
+* xref:rpk/rpk-connect/rpk-connect-agent-run.adoc[]: Execute a Redpanda Connect agent as part of a pipeline with MCP tool access.

Based on learnings: "AsciiDoc linking: prefer using xref links with empty brackets (e.g., xref:section/target.adoc[]) because the title is pulled from the referenced document automatically."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/reference/pages/rpk/rpk-connect/rpk-connect-agent.adoc` around lines
17 - 18, Replace the hard-coded xref link text in rpk-connect-agent.adoc so
titles are auto-pulled: change
xref:rpk/rpk-connect/rpk-connect-agent-init.adoc[init] to
xref:rpk/rpk-connect/rpk-connect-agent-init.adoc[] and
xref:rpk/rpk-connect/rpk-connect-agent-run.adoc[run] to
xref:rpk/rpk-connect/rpk-connect-agent-run.adoc[] (update the two xref usages
shown in the diff).

1-29: Consider updating the parent page to list subcommands.

The parent page rpk-connect.adoc (referenced in context) lacks a "Subcommands" or "Commands" section that would enumerate available subcommands like agent, dry-run, and plugin. While navigation provides access, including a subcommands section on the parent page would improve discoverability for users.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/reference/pages/rpk/rpk-connect/rpk-connect-agent.adoc` around lines
1 - 29, Parent page rpk-connect.adoc is missing a "Subcommands" section to list
available subcommands (agent, dry-run, plugin); add a Subcommands or Commands
section to rpk-connect.adoc that enumerates each subcommand with short
descriptions and xref links (e.g.,
xref:rpk/rpk-connect/rpk-connect-agent.adoc[rpk connect agent],
xref:rpk/rpk-connect/rpk-connect-dry-run.adoc[rpk connect dry-run],
xref:rpk/rpk-connect/rpk-connect-plugin.adoc[rpk connect plugin]) so users can
discover and navigate to the specific pages directly from the parent page.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@modules/reference/pages/rpk/rpk-connect/rpk-connect-agent.adoc`:
- Around line 17-18: Replace the hard-coded xref link text in
rpk-connect-agent.adoc so titles are auto-pulled: change
xref:rpk/rpk-connect/rpk-connect-agent-init.adoc[init] to
xref:rpk/rpk-connect/rpk-connect-agent-init.adoc[] and
xref:rpk/rpk-connect/rpk-connect-agent-run.adoc[run] to
xref:rpk/rpk-connect/rpk-connect-agent-run.adoc[] (update the two xref usages
shown in the diff).
- Around line 1-29: Parent page rpk-connect.adoc is missing a "Subcommands"
section to list available subcommands (agent, dry-run, plugin); add a
Subcommands or Commands section to rpk-connect.adoc that enumerates each
subcommand with short descriptions and xref links (e.g.,
xref:rpk/rpk-connect/rpk-connect-agent.adoc[rpk connect agent],
xref:rpk/rpk-connect/rpk-connect-dry-run.adoc[rpk connect dry-run],
xref:rpk/rpk-connect/rpk-connect-plugin.adoc[rpk connect plugin]) so users can
discover and navigate to the specific pages directly from the parent page.

In `@modules/reference/pages/rpk/rpk-connect/rpk-connect-plugin.adoc`:
- Line 17: Replace the hard-coded xref text `[init]` with empty brackets `[]` so
the link auto-pulls the target page title; update the xref in the
rpk-connect-plugin.adoc line referencing rpk-connect-plugin-init.adoc
(xref:rpk/rpk-connect/rpk-connect-plugin-init.adoc[]).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 12e93d25-7268-40ea-a8ff-661e4098ed7e

📥 Commits

Reviewing files that changed from the base of the PR and between fe8a357 and 8804181.

📒 Files selected for processing (7)
  • modules/ROOT/nav.adoc
  • modules/reference/pages/rpk/rpk-connect/rpk-connect-agent-init.adoc
  • modules/reference/pages/rpk/rpk-connect/rpk-connect-agent-run.adoc
  • modules/reference/pages/rpk/rpk-connect/rpk-connect-agent.adoc
  • modules/reference/pages/rpk/rpk-connect/rpk-connect-dry-run.adoc
  • modules/reference/pages/rpk/rpk-connect/rpk-connect-plugin-init.adoc
  • modules/reference/pages/rpk/rpk-connect/rpk-connect-plugin.adoc

@prakhargarg105
Copy link

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants