Skip to content

review fixes: chroot flags, dry-run usage, plugin-init example#1616

Merged
mfernest merged 1 commit intoredpanda-data:fix/doc-1970-rpk-connect-referencefrom
mmatczuk:fix/doc-1970-rpk-connect-reference
Mar 18, 2026
Merged

review fixes: chroot flags, dry-run usage, plugin-init example#1616
mfernest merged 1 commit intoredpanda-data:fix/doc-1970-rpk-connect-referencefrom
mmatczuk:fix/doc-1970-rpk-connect-reference

Conversation

@mmatczuk
Copy link

Review fixes for #1608:

  • rpk-connect-agent-run.adoc: add Linux-only --chroot and --chroot-passthrough flags
  • rpk-connect-dry-run.adoc: fix Usage line from [command options] to [OPTIONS] [files...]
  • rpk-connect-plugin-init.adoc: add Example section

@mmatczuk mmatczuk requested a review from a team as a code owner March 18, 2026 15:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8d58467e-cd7c-4087-839d-140ca66b4e35

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

[,bash]
----
rpk connect plugin init ./my-plugin
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our style guide, we avoid possessive prefixes like my- in examples. Would ./example-plugin or similar work here instead?

@mfernest mfernest merged commit ade95c3 into redpanda-data:fix/doc-1970-rpk-connect-reference Mar 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants