fix(scorecard): add threshold-based status colors to entities table#2640
fix(scorecard): add threshold-based status colors to entities table#2640Eswaraiahsapram wants to merge 13 commits intoredhat-developer:mainfrom
Conversation
Changed Packages
|
Review Summary by QodoMigrate to react-query and add threshold-based status colors for entities
WalkthroughsDescription• Migrate data fetching from react-use to @tanstack/react-query for better caching and state management • Add threshold-based status colors to entities table with new getThresholdRuleColor utility • Wrap scorecard components with ScorecardQueryProvider for standalone homepage rendering • Fix ownership loading state handling in entities table to prevent premature data display Diagramflowchart LR
A["react-use hooks"] -->|"migrate to"| B["@tanstack/react-query"]
B -->|"enables"| C["QueryClientProvider wrapper"]
C -->|"supports"| D["Standalone component rendering"]
E["Threshold rules"] -->|"compute"| F["Status colors"]
F -->|"applied to"| G["MetricStatusCell"]
H["Ownership loading state"] -->|"fix"| I["Prevent premature rendering"]
File Changes1. workspaces/scorecard/plugins/scorecard/src/hooks/useAggregatedScorecard.tsx
|
Code Review by Qodo
|
c07674e to
ee734b5
Compare
ee734b5 to
d7fa700
Compare
f0f9874 to
a96704f
Compare
|
Thanks @Eswaraiahsapram , tested the pr locally in both legacy and nfs mode. Looks good to me. 🎉 Screen.Recording.2026-04-07.at.11.49.33.AM.mov |
|
New changes are detected. LGTM label has been removed. |
419f3b4 to
65e82cd
Compare
6a72aad to
0a67320
Compare
d38e5bf to
a264dc9
Compare
|




Hey, I just made a Pull Request!
Fix
Description
Screenshots
Customized status colors
Screen.Recording.2026-03-30.at.1.34.07.PM.mov
Customized titles
✔️ Checklist