Skip to content

Commit a264dc9

Browse files
fix e2e tests
1 parent 54058aa commit a264dc9

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

workspaces/scorecard/packages/app-legacy/e2e-tests/pages/ScorecardDrillDownPage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ export class ScorecardDrillDownPage {
6565
}
6666
}
6767

68-
async expectPageTitle(metricId: MetricId) {
68+
async expectPageTitle(metricId: MetricId, customTitle?: string) {
6969
await expect(
7070
this.page.getByRole('heading', {
71-
name: this.translations.metric[metricId].title,
71+
name: customTitle ?? this.translations.metric[metricId].title,
7272
level: 1,
7373
}),
7474
).toBeVisible();

workspaces/scorecard/packages/app-legacy/e2e-tests/scorecard.test.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,10 @@ test.describe('Scorecard Plugin Tests', () => {
710710
await scorecardDrillDownPage.expectOnPage('github.open_prs', {
711711
aggregationId: AGGREGATED_CARDS_METRIC_IDS.withGithubOpenPrs,
712712
});
713-
await scorecardDrillDownPage.expectPageTitle('github.open_prs');
713+
await scorecardDrillDownPage.expectPageTitle(
714+
'github.open_prs',
715+
githubAggregatedResponse.metadata.title,
716+
);
714717
await scorecardDrillDownPage.expectDrillDownCardSnapshot(
715718
'github.open_prs',
716719
{
@@ -824,7 +827,10 @@ test.describe('Scorecard Plugin Tests', () => {
824827
await scorecardDrillDownPage.expectOnPage('jira.open_issues', {
825828
aggregationId: AGGREGATED_CARDS_METRIC_IDS.withJiraOpenIssuesKpi,
826829
});
827-
await scorecardDrillDownPage.expectPageTitle('jira.open_issues');
830+
await scorecardDrillDownPage.expectPageTitle(
831+
'jira.open_issues',
832+
jiraAggregatedResponse.metadata.title,
833+
);
828834
await scorecardDrillDownPage.expectDrillDownCardSnapshot(
829835
'jira.open_issues',
830836
{

0 commit comments

Comments
 (0)