[code-quality] Add AddReturnTypeToDependedRector #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-return-method-type
branch
3 times, most recently
from
385469f to
1cc7895
Compare
TomasVotruba
force-pushed
the
tv-return-method-type
branch
from
1cc7895 to
f3da56d
Compare
samsonasik
requested changes
Sep 1, 2025
rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php
Outdated
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-return-method-type
branch
from
f3da56d to
4471d55
Compare
Member
Author
|
Rector is failing because of different config locations. I'll add dummy set list to have them in relative paths |
Member
|
The config is fine, just 'rector-src/vendor |
Member
Author
|
@samsonasik No need to check magic paths, better use this way rectorphp/rector-symfony#837 |
samsonasik
reviewed
Sep 1, 2025
rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Sep 1, 2025
TomasVotruba
force-pushed
the
tv-return-method-type
branch
from
78bbcb0 to
bfdc0fc
Compare
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
TomasVotruba
force-pushed
the
tv-return-method-type
branch
from
bfdc0fc to
44b19d6
Compare
samsonasik
requested changes
Sep 1, 2025
Comment on lines
+100
to
+102
| if (! $this->haveAllReturnsExpr($classMethod)) { | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
this can be removed.
Suggested change
| if (! $this->haveAllReturnsExpr($classMethod)) { | |
| continue; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.