Skip to content

Commit bfdc0fc

Browse files
Update rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
1 parent 4471d55 commit bfdc0fc

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
1414
use Rector\Rector\AbstractRector;
1515
use Rector\StaticTypeMapper\StaticTypeMapper;
16-
use Rector\TypeDeclaration\TypeInferer\SilentVoidResolver;
16+
use Rector\TypeDeclaration\NodeAnalyzer\ReturnAnalyzer;
1717
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
1818
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
1919

@@ -24,7 +24,7 @@ final class AddReturnTypeToDependedRector extends AbstractRector
2424
{
2525
public function __construct(
2626
private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
27-
private readonly SilentVoidResolver $silentVoidResolver,
27+
private readonly ReturnAnalyzer $returnAnalyzer,
2828
private readonly StaticTypeMapper $staticTypeMapper,
2929
private readonly BetterNodeFinder $betterNodeFinder
3030
) {
@@ -106,11 +106,10 @@ public function refactor(Node $node): ?Node
106106
continue;
107107
}
108108

109-
if ($this->silentVoidResolver->hasSilentVoid($classMethod)) {
110-
continue;
111-
}
112-
113109
$returns = $this->betterNodeFinder->findReturnsScoped($classMethod);
110+
if (! $this->returnAnalyzer->hasOnlyReturnWithExpr($classMethod, $returns)) {
111+
return null;
112+
}
114113
if (count($returns) !== 1) {
115114
continue;
116115
}

0 commit comments

Comments
 (0)