Adds AssertCountWithZeroToAssertEmptyRector rule

[peterfox]

Changes

• Adds a new AssertCountWithZeroToAssertEmptyRector.
• Adds tests for the rule.
• Added to code quality set.

Why

This is just a small but useful rector rule. It will convert use of assertCount with a first parameter of zero to be assertEmpty. Also handles the not use as well.

-$this->assertCount(0, $array);
+$this->assertEmpty($array);
-$this->assertNotCount(0, $array);
+$this->assertNotEmpty($array);

[TomasVotruba]

Thanks Peter, this looks good 👍

We could add it to the code quality set, what do you think?

[peterfox]

Will do @TomasVotruba !

[TomasVotruba]

Lets ship it 😉

Thank you

[samsonasik]

@peterfox It seems buggy on combine with AssertEmptyNullableObjectToAssertInstanceofRector

-        $this->assertCount(0, $this->bar->baz());
+        $this->assertNotInstanceOf(Collection::class, $this->bar->baz());
     }
    ----------- end diff -----------

Applied rules:
 * AssertCountWithZeroToAssertEmptyRector
 * AssertEmptyNullableObjectToAssertInstanceofRector

that cause error:

Failed asserting that an object is not an instance of interface Doctrine\Common\Collections\Collection.

I will check if that resolvable

[samsonasik]

@peterfox I created new PR to skip union type on :

• [CodeQuality] Skip union type on AssertCountWithZeroToAssertEmptyRector #459

[TomasVotruba]

I'm looking into this rule once again, as it actually creates less readable code. We ignore it completely on couple of projects.
empty() is too vague structure and PHPStan and Rector rules try to refactor away form it.

Also in $this->assertCount(x, ...) is more readable in context of similar counter tests:

$this->assertCount(1, ...);
$this->assertCount(5, ...);
$this->assertCount(0, ...);

Saying that, I'll deprecate and remove this rule form the set, to promote higher quality code.

Thanks for understanding 👍