[deprecated] Deprecate AssertCountWithZeroToAssertEmptyRector to improve test readability with more explicit methods #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #456 (comment)
I'm looking into this rule once again, as it actually creates less readable code. We ignore it completely on couple of projects.
empty()is too vague structure and PHPStan and Rector rules try to refactor away form it.Also in
$this->assertCount(x, ...)is more readable in context of similar counter tests:Saying that, I'll deprecate and remove this rule form the set, to promote higher quality code 👍