Skip to content

Auto-scroll to first non-empty search item in case of pinned providers. #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsp1020 wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −1
Open

Auto-scroll to first non-empty search item in case of pinned providers. #2546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion app/src/main/java/com/lagradost/cloudstream3/ui/search/SearchFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,38 @@ class SearchFragment : BaseFragment<FragmentSearchBinding>(
}

submitList(newItems)
//notifyDataSetChanged()

val firstNonEmptyIndex = newItems.indexOfFirst { it.list.list.isNotEmpty() }
if (firstNonEmptyIndex != -1 && pinnedOrder.isNotEmpty()) {
val masterRecycler = binding.searchMasterRecycler

masterRecycler.post {
try {
masterRecycler.scrollToPosition(firstNonEmptyIndex)
Copy link
Copy Markdown
Collaborator

@fire-light42 fire-light42 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it impossible for users to scroll down while the results are loading. Make sure the user inputs take precedence over anything you are doing automatically.

This is best tested by installing many providers, you will see it becomes impossible to do anything while new results appear.


masterRecycler.post {
val parentVH = masterRecycler.findViewHolderForAdapterPosition(firstNonEmptyIndex)
val parentView = parentVH?.itemView
?: masterRecycler.layoutManager?.findViewByPosition(firstNonEmptyIndex)

val childRecycler = parentView
?.findViewById<androidx.recyclerview.widget.RecyclerView>(R.id.home_child_recyclerview)

childRecycler?.post {
val firstChild =
childRecycler.layoutManager?.findViewByPosition(0)
?: childRecycler.findViewHolderForAdapterPosition(0)?.itemView

firstChild?.let { view ->
view.isFocusableInTouchMode = true
view.requestFocus()
Copy link
Copy Markdown
Collaborator

@fire-light42 fire-light42 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not focus the item unless necessary. This steals focus from the user on a TV, and it focuses when the user is on a phone (which should never happen).

}
}
}
} catch (_: Throwable) {
}
}
}
}
} catch (e: Exception) {
logError(e)
Expand Down