Auto-scroll to first non-empty search item in case of pinned providers.#2546
Auto-scroll to first non-empty search item in case of pinned providers.#2546hsp1020 wants to merge 1 commit intorecloudstream:masterfrom
Conversation
|
I opened this PR several weeks ago, but haven't received any feedback yet. Is there a reason for the delay? I'd appreciate it if you could let me know when you might be able to review it. Thanks. |
|
Sorry, there have simply been too many pull requests for me to review everything in a timely manner. |
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Good idea, but requires refinement for a better UX.
|
|
||
| firstChild?.let { view -> | ||
| view.isFocusableInTouchMode = true | ||
| view.requestFocus() |
There was a problem hiding this comment.
Do not focus the item unless necessary. This steals focus from the user on a TV, and it focuses when the user is on a phone (which should never happen).
|
|
||
| masterRecycler.post { | ||
| try { | ||
| masterRecycler.scrollToPosition(firstNonEmptyIndex) |
There was a problem hiding this comment.
This makes it impossible for users to scroll down while the results are loading. Make sure the user inputs take precedence over anything you are doing automatically.
This is best tested by installing many providers, you will see it becomes impossible to do anything while new results appear.
2 participants
This PR re-submits the changes from #2507, which was closed because the head repository was deleted.