-
Notifications
You must be signed in to change notification settings - Fork 835
[ET-VK] Migrate to use new q8ta_conv2d ops #17388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/SS-JIA/419/base
Are you sure you want to change the base?
Conversation
This renames the quantized convolution custom ops from the old `conv2d_q8ta_q8csw_q8to` naming convention to the shorter `q8ta_conv2d` convention, and moves operator registrations from the `etvk` namespace to the standard `et_vk` namespace. A new `q8ta_conv2d_pw` op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation. Changes: - custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition - op_registry.py: Split registration into separate PW and non-PW entries - quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw - Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace - TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace Differential Revision: [D93000168](https://our.internmc.facebook.com/intern/diff/D93000168/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17388
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 34140eb with merge base 964c565 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This renames the quantized convolution custom ops from the old `conv2d_q8ta_q8csw_q8to` naming convention to the shorter `q8ta_conv2d` convention, and moves operator registrations from the `etvk` namespace to the standard `et_vk` namespace. A new `q8ta_conv2d_pw` op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation. Changes: - custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition - op_registry.py: Split registration into separate PW and non-PW entries - quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw - Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace - TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace Differential Revision: [D93000168](https://our.internmc.facebook.com/intern/diff/D93000168/) [ghstack-poisoned]
This renames the quantized convolution custom ops from the old `conv2d_q8ta_q8csw_q8to` naming convention to the shorter `q8ta_conv2d` convention, and moves operator registrations from the `etvk` namespace to the standard `et_vk` namespace. A new `q8ta_conv2d_pw` op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation. Changes: - custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition - op_registry.py: Split registration into separate PW and non-PW entries - quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw - Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace - TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace Differential Revision: [D93000168](https://our.internmc.facebook.com/intern/diff/D93000168/) [ghstack-poisoned]
Stack from ghstack (oldest at bottom):
This renames the quantized convolution custom ops from the old
conv2d_q8ta_q8csw_q8tonaming convention to the shorterq8ta_conv2dconvention, and moves operator registrations from theetvknamespace to the standardet_vknamespace. A newq8ta_conv2d_pwop is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation.Changes:
Differential Revision: D93000168