Skip to content

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Feb 11, 2026

Stack from ghstack (oldest at bottom):

This renames the quantized convolution custom ops from the old conv2d_q8ta_q8csw_q8to naming convention to the shorter q8ta_conv2d convention, and moves operator registrations from the etvk namespace to the standard et_vk namespace. A new q8ta_conv2d_pw op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation.

Changes:

  • custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition
  • op_registry.py: Split registration into separate PW and non-PW entries
  • quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw
  • Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace
  • TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace

Differential Revision: D93000168

This renames the quantized convolution custom ops from the old `conv2d_q8ta_q8csw_q8to` naming convention to the shorter `q8ta_conv2d` convention, and moves operator registrations from the `etvk` namespace to the standard `et_vk` namespace. A new `q8ta_conv2d_pw` op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation.

Changes:
- custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition
- op_registry.py: Split registration into separate PW and non-PW entries
- quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw
- Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace
- TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace

Differential Revision: [D93000168](https://our.internmc.facebook.com/intern/diff/D93000168/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 11, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17388

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 34140eb with merge base 964c565 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This renames the quantized convolution custom ops from the old `conv2d_q8ta_q8csw_q8to` naming convention to the shorter `q8ta_conv2d` convention, and moves operator registrations from the `etvk` namespace to the standard `et_vk` namespace. A new `q8ta_conv2d_pw` op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation.

Changes:
- custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition
- op_registry.py: Split registration into separate PW and non-PW entries
- quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw
- Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace
- TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace

Differential Revision: [D93000168](https://our.internmc.facebook.com/intern/diff/D93000168/)

[ghstack-poisoned]
This renames the quantized convolution custom ops from the old `conv2d_q8ta_q8csw_q8to` naming convention to the shorter `q8ta_conv2d` convention, and moves operator registrations from the `etvk` namespace to the standard `et_vk` namespace. A new `q8ta_conv2d_pw` op is also introduced for pointwise (1x1 stride-1 no-padding) convolutions, allowing the pattern matcher to route these to a specialized implementation.

Changes:
- custom_ops_lib.py: Rename functions and op names; add q8ta_conv2d_pw definition
- op_registry.py: Split registration into separate PW and non-PW entries
- quantized_convolution.py: Add pointwise conv detection and routing to q8ta_conv2d_pw
- Q8taConv2d.cpp, Q8taConv2dDW.cpp, Q8taConv2dPW.cpp, Q8taConv2dIm2Col.cpp: Change VK_REGISTER_OP from etvk to et_vk namespace
- TestQ8taConv2d.cpp: Update operator name strings to et_vk namespace

Differential Revision: [D93000168](https://our.internmc.facebook.com/intern/diff/D93000168/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant