-
Notifications
You must be signed in to change notification settings - Fork 835
[ET-VK][qconv][ez] Make q8ta_im2col shader support stride_w != 1 #17386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/SS-JIA/417/base
Are you sure you want to change the base?
Conversation
The im2col path previously had two shaders: the generic `q8ta_im2col` which loaded input elements one int8 at a time and supported all strides, and `q8ta_im2col_4w4c` which loaded packed int32s (4 channels at once) but was restricted to stride_w == 1 because it assumed consecutive width positions in the input (i.e. `input_x_base + i`). This diff replaces both shaders with a single `q8ta_im2col` that uses the efficient packed loading approach from `q8ta_im2col_4w4c` while generalizing the width offset to `input_x_base + i * stride_x`. This removes the stride_w == 1 restriction and deletes the separate `q8ta_im2col_4w4c` shader entirely. The C++ dispatch is updated to reference the unified shader name, and the test gate on `stride.w == 1` for the im2col path is removed. Authored with Claude. Differential Revision: [D93000161](https://our.internmc.facebook.com/intern/diff/D93000161/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17386
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e7abc43 with merge base 964c565 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
…w != 1" The im2col path previously had two shaders: the generic `q8ta_im2col` which loaded input elements one int8 at a time and supported all strides, and `q8ta_im2col_4w4c` which loaded packed int32s (4 channels at once) but was restricted to stride_w == 1 because it assumed consecutive width positions in the input (i.e. `input_x_base + i`). This diff replaces both shaders with a single `q8ta_im2col` that uses the efficient packed loading approach from `q8ta_im2col_4w4c` while generalizing the width offset to `input_x_base + i * stride_x`. This removes the stride_w == 1 restriction and deletes the separate `q8ta_im2col_4w4c` shader entirely. The C++ dispatch is updated to reference the unified shader name, and the test gate on `stride.w == 1` for the im2col path is removed. Authored with Claude. Differential Revision: [D93000161](https://our.internmc.facebook.com/intern/diff/D93000161/) [ghstack-poisoned]
…w != 1" The im2col path previously had two shaders: the generic `q8ta_im2col` which loaded input elements one int8 at a time and supported all strides, and `q8ta_im2col_4w4c` which loaded packed int32s (4 channels at once) but was restricted to stride_w == 1 because it assumed consecutive width positions in the input (i.e. `input_x_base + i`). This diff replaces both shaders with a single `q8ta_im2col` that uses the efficient packed loading approach from `q8ta_im2col_4w4c` while generalizing the width offset to `input_x_base + i * stride_x`. This removes the stride_w == 1 restriction and deletes the separate `q8ta_im2col_4w4c` shader entirely. The C++ dispatch is updated to reference the unified shader name, and the test gate on `stride.w == 1` for the im2col path is removed. Authored with Claude. Differential Revision: [D93000161](https://our.internmc.facebook.com/intern/diff/D93000161/) [ghstack-poisoned]
Stack from ghstack (oldest at bottom):
The im2col path previously had two shaders: the generic
q8ta_im2colwhich loaded input elements one int8 at a time and supported all strides,
and
q8ta_im2col_4w4cwhich loaded packed int32s (4 channels at once)but was restricted to stride_w == 1 because it assumed consecutive
width positions in the input (i.e.
input_x_base + i).This diff replaces both shaders with a single
q8ta_im2colthat usesthe efficient packed loading approach from
q8ta_im2col_4w4cwhilegeneralizing the width offset to
input_x_base + i * stride_x. Thisremoves the stride_w == 1 restriction and deletes the separate
q8ta_im2col_4w4cshader entirely.The C++ dispatch is updated to reference the unified shader name, and
the test gate on
stride.w == 1for the im2col path is removed.Authored with Claude.
Differential Revision: D93000161