-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 12: Allow "Pending" as Discussions-To #4361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 Definitely in favour. |
AA-Turner
reviewed
Apr 9, 2025
Member
|
Huge +1, as there's always the "publish PEP, start the DPO thread, update the PEP dance" That said, I'd bikeshed against using an initialism, and just go with "Pending" |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk
commented
Apr 10, 2025
AA-Turner
approved these changes
Apr 10, 2025
brettcannon
approved these changes
Apr 10, 2025
Member
|
I went ahead and merged as Barry and I were +1 and everyone overall seemed positive on the idea. |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's often confusion about whether the discussion thread should be created before or after the draft PEP has been merged.
It's often better to merge the PEP first, and the the thread can use the https://peps.python.org/ URL instead of disseminating a temporary RTD URL that will soon be outdated and later deleted.
The linter is confusing too: "Discussions-To must be a valid thread URL or mailing list" makes some think the thread must be created first to pass, it's not obvious they can omit the field to satisfy the linter.
Finally, PEP 12 says "it is okay to just list the venue name initially" but the linter requires a thread or ML URL.
Instead, I think it may improve things if authors can write
"Discussions-To: TBA""Discussions-To: Pending" without the linter complaining. We can then merge the draft PR, they can open the thread, and then replace theTBAPending.📚 Documentation preview 📚: https://pep-previews--4361.org.readthedocs.build/