Skip to content

Conversation

@methane
Copy link
Member

@methane methane commented Mar 24, 2025

Ref: https://discuss.python.org/t/pep-781-adding-type-checking-constant/85728

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4318.org.readthedocs.build/pep-0781/

@methane methane requested a review from a team as a code owner March 24, 2025 01:40
@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Mar 24, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PEP!

I've added the new PEP checklist to the PR description, please could you check things off as appropriate?

@AA-Turner AA-Turner self-requested a review March 25, 2025 01:11
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial/review comments, I'll also comment on the Discouse thread with more substantive points.

A

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
methane and others added 2 commits March 26, 2025 21:27
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@methane methane changed the title PEP 781: Adding __type_checking__ constant PEP 781: Adding TYPE_CHECKING builtin constant Mar 27, 2025
@methane methane changed the title PEP 781: Adding TYPE_CHECKING builtin constant PEP 781: Make TYPE_CHECKING builtin Mar 27, 2025
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial/grammatical suggestions:

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Vincent Poulailleau <vpoulailleau@gmail.com>
@AA-Turner AA-Turner changed the title PEP 781: Make TYPE_CHECKING builtin PEP 781: Make TYPE_CHECKING a built-in constant Mar 28, 2025
@AA-Turner
Copy link
Member

Read the docs is failing with " fatal: reference is not a tree", but everything else is passing.

A

@AA-Turner AA-Turner merged commit 87cf871 into python:main Mar 28, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants