Skip to content

Prevent slow-to-start containers from trying to run in the same slot #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kr-t merged 3 commits into from
Dec 18, 2025
Merged

Prevent slow-to-start containers from trying to run in the same slot #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ba5780
Reserve slot for container once identified. Prevents race condition w…
dkouba-atym Dec 17, 2025
c34b7bc
Fix bracket typo
kr-t Dec 17, 2025
11670af
Fix clang
kr-t Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ocre/components/container_supervisor/cs_sm_impl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,8 @@ ocre_container_status_t CS_create_container(ocre_container_t *container)
}

if (container->container_runtime_status != CONTAINER_STATUS_UNKNOWN &&
container->container_runtime_status != CONTAINER_STATUS_DESTROYED) {
container->container_runtime_status != CONTAINER_STATUS_DESTROYED &&
container->container_runtime_status != CONTAINER_STATUS_RESERVED) {
LOG_ERR("Cannot create container again container with ID: %d, already exists", curr_container_ID);
return CONTAINER_STATUS_ERROR;
}
Expand Down
1 change: 1 addition & 0 deletions src/ocre/ocre_container_runtime/ocre_container_runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ ocre_container_status_t ocre_container_runtime_create_container(ocre_cs_ctx *ctx
(ctx->containers[i].container_runtime_status == CONTAINER_STATUS_DESTROYED)) {
*container_id = i;
ctx->containers[i].container_ID = i;
ctx->containers[i].container_runtime_status = CONTAINER_STATUS_RESERVED;
validity_flag = true;
break;
}
Expand Down
1 change: 1 addition & 0 deletions src/ocre/ocre_container_runtime/ocre_container_runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ typedef enum {
*/
typedef enum {
CONTAINER_STATUS_UNKNOWN, ///< Status is unknown.
CONTAINER_STATUS_RESERVED, ///< Container slot has been reserved.
CONTAINER_STATUS_CREATED, ///< Container has been created.
CONTAINER_STATUS_RUNNING, ///< Container is currently running.
CONTAINER_STATUS_STOPPED, ///< Container has been stopped.
Expand Down