Skip to content

Conversation

@dkouba-atym
Copy link
Contributor

@dkouba-atym dkouba-atym commented Dec 17, 2025

Quick fix for multi-container startup race condition when a container is slow to start. Container slots remain free until container startup is complete, meaning multiple containers can identify the same slot as open to occupy. This fix creates a reserved state that is immediately applied to an open container slot once identified.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Also, please list any issue that this PR is intended to fix.

  • Fixes issue #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration including the following required details.

Test Configuration (required):

  • Host OS type, version, and arch: Ubuntu 20.04 (arm64)
  • Developer Board make & model: ST Nucleo h723zg
  • Board Tools Installed: STM32CubeProgrammer)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…here containers start in the same slot if slow to start.

Signed-off-by: Dan Kouba <dan@atym.io>
kr-t added 2 commits December 17, 2025 21:32
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
@kr-t kr-t merged commit 90cb917 into main Dec 18, 2025
24 checks passed
@kr-t kr-t deleted the bugs/container-slot-reservation branch December 18, 2025 14:31
casaroli added a commit that referenced this pull request Jan 7, 2026
…me slot (#114)"

This reverts commit 90cb917.

This commit is kept in the legacy branch.
casaroli added a commit that referenced this pull request Jan 7, 2026
…me slot (#114)"

This reverts commit 90cb917.

This commit is kept in the legacy branch.

Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli added a commit that referenced this pull request Jan 7, 2026
…me slot (#114)"

This reverts commit 90cb917.

This commit is kept in the legacy branch.

Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants