fix: replace console.log/warn with p5._friendlyError in RendererGL (fixes #8591)#8592
Open
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Open
fix: replace console.log/warn with p5._friendlyError in RendererGL (fixes #8591)#8592MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Conversation
- p5.RendererGL.js: Replace 6 console.log/warn calls with p5._friendlyError() (setAttributes, dimension limits, blendMode, loadPixels, tesselation) - p5.RendererGL.Immediate.js: Replace 2 console.log/warn calls with p5._friendlyError() (vertex texture warning, instancing) - All messages now respect p5.disableFriendlyErrors setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 8
console.log/console.warncalls across p5.RendererGL.js and p5.RendererGL.Immediate.js withp5._friendlyError().Resolves #8591
Changes
All messages now respect
p5.disableFriendlyErrors.Notes