Conversation
csouchet
added
the
dependencies
|
@csouchet this PR is going to have a very large scope (both config change and update of eslint rules) I'd like to be able to review it more quickly than process-analytics/bpmn-visualization-js#3081. |
csouchet
force-pushed
the
chore/eslint9
branch
from
15666ba to
8e0905e
Compare
csouchet
added
the
depends on another PR ⚠️
|
🎊 PR Preview e0eb8ef has been successfully built and deployed to https://process-analytics-bpmn-visualization-addons-demo-pr-375.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
|
Converted to draft, as the PR depends on #376 |
csouchet
force-pushed
the
chore/eslint9
branch
from
972c51f to
ae73e19
Compare
- Add typescript-eslint and @eslint/js - Remove @typescript-eslint/eslint-plugin and @typescript-eslint/parser
csouchet
force-pushed
the
chore/eslint9
branch
2 times, most recently
from
60f7e7f to
8783e4d
Compare
|
|
| */ | ||
|
|
||
| import type { Overlay } from 'bpmn-visualization'; | ||
| // eslint-disable-next-line n/no-extraneous-import |
There was a problem hiding this comment.
question: why adding this? this plugin is not supposed to be bump and when using it with eslint v8, there is no need to disable the rule here.
| "strict": true, | ||
| "noEmit": true, | ||
| "skipLibCheck": false, | ||
| "paths": { |
There was a problem hiding this comment.
question: verify if this is really needed. May be required if the addons package is not built.
| import './assets/overlays.css'; | ||
| import type { FitOptions } from 'bpmn-visualization'; | ||
|
|
||
| // eslint-disable-next-line n/file-extension-in-import, n/no-missing-import |
There was a problem hiding this comment.
question: verify if this is really needed. May be required if the addons package is not built.
This remark applies to all demo code.
| } | ||
|
|
||
| export class ShapeUtil extends BaseShapeUtil { | ||
| export class ShapeUtility extends BaseShapeUtility { |
There was a problem hiding this comment.
issue: renaming ShapeUtil is a breaking change. This should not be done as part of an eslint configuration change.
|
Closing. This PR will be recreated from the main branch and will not include bump of the unicorn plugin. This will be done later. |
2 participants
Depends on #376